Re: [Mesa-dev] [PATCH 4/4] vc4: unref old fence

2015-07-09 Thread Rob Clark
On Thu, Jul 9, 2015 at 8:36 AM, Emil Velikov wrote: > On 9 July 2015 at 01:46, Rob Clark wrote: >> From: Rob Clark >> >> Some, but not all, state trackers will explicitly unref (and set to >> NULL) the previous *fence before calling pipe->flush(). So driver >> should use fence_ref() which will

Re: [Mesa-dev] [PATCH 4/4] vc4: unref old fence

2015-07-09 Thread Emil Velikov
On 9 July 2015 at 01:46, Rob Clark wrote: > From: Rob Clark > > Some, but not all, state trackers will explicitly unref (and set to > NULL) the previous *fence before calling pipe->flush(). So driver > should use fence_ref() which will unref the old fence if not NULL. > > Signed-off-by: Rob Clar

Re: [Mesa-dev] [PATCH 4/4] vc4: unref old fence

2015-07-08 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > Some, but not all, state trackers will explicitly unref (and set to > NULL) the previous *fence before calling pipe->flush(). So driver > should use fence_ref() which will unref the old fence if not NULL. > > Signed-off-by: Rob Clark Acked-by: Eric Anho

[Mesa-dev] [PATCH 4/4] vc4: unref old fence

2015-07-08 Thread Rob Clark
From: Rob Clark Some, but not all, state trackers will explicitly unref (and set to NULL) the previous *fence before calling pipe->flush(). So driver should use fence_ref() which will unref the old fence if not NULL. Signed-off-by: Rob Clark --- src/gallium/drivers/vc4/vc4_context.c | 2 ++ 1

[Mesa-dev] [PATCH 4/4] vc4: unref old fence

2015-07-08 Thread Rob Clark
From: Rob Clark Some, but not all, state trackers will explicitly unref (and set to NULL) the previous *fence before calling pipe->flush(). So driver should use fence_ref() which will unref the old fence if not NULL. Signed-off-by: Rob Clark --- src/gallium/drivers/vc4/vc4_context.c | 3 ++-