Re: [Mesa-dev] [PATCH 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-02 Thread Kyriazis, George
Please use LLVM defines consistent with the surrounding code. Surrounding code uses LLVM_VERSION_MAJOR / LLVM_VERSION_MINOR. This code should then be: #if LLVM_VERSION_MAJOR >= 7 … #endif Thank you! George > On Apr 1, 2018, at 3:05 PM, Vinson Lee wrote: > > On Sun, Apr 1, 2018 at 1:10 AM,

Re: [Mesa-dev] [PATCH 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-01 Thread Vinson Lee
On Sun, Apr 1, 2018 at 1:10 AM, Mike Lothian wrote: > Include llvm/Transforms/Utils.h with the newest LLVM 7 > > Signed-of-by: Mike Lothian > --- > src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/drivers/swr/rasterizer

[Mesa-dev] [PATCH 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-01 Thread Mike Lothian
Include llvm/Transforms/Utils.h with the newest LLVM 7 Signed-of-by: Mike Lothian --- src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp b/src/gallium/drivers/swr/rasterizer/jitter/ji