Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-06 Thread Emil Velikov
Hello Leo, On 6 November 2015 at 16:00, Liu, Leo wrote: > Hi Emil, > >>Shorten the variable name - OMX_RENDER_NODE ? debug_get_option is only >>available on debug builds so better use getenv. >> > > The debug_get_*_option() functions are used all around mesa, and functions > are explicitly prefe

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-06 Thread Emil Velikov
On 6 November 2015 at 03:19, Liu, Leo wrote: >>-Original Message- >>From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >>Sent: Thursday, November 05, 2015 6:30 PM >>To: Liu, Leo >>Cc: ML mesa-dev >>Subject: Re: [Mesa-dev] [PATCH 4/4] st/omx: add head

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-06 Thread Liu, Leo
Hi Emil, >Shorten the variable name - OMX_RENDER_NODE ? debug_get_option is only >available on debug builds so better use getenv. > The debug_get_*_option() functions are used all around mesa, and functions are explicitly preferred to working with getenv() directly. Regards, Leo >omx_render_n

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-05 Thread Liu, Leo
>-Original Message- >From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >Sent: Thursday, November 05, 2015 6:30 PM >To: Liu, Leo >Cc: ML mesa-dev >Subject: Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support > >On 5 November 2015 at 18:47, Leo Liu wrote: &g

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 18:47, Leo Liu wrote: > This will allow dec/enc/transcode without X > Are we talking about multi GPU setup where X is running on one, and OMX on another, or a true "without X" case ? I'm leaning that the latter isn't really possible, yet. > Signed-off-by: Leo Liu > --- > s

[Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-05 Thread Leo Liu
This will allow dec/enc/transcode without X Signed-off-by: Leo Liu --- src/gallium/state_trackers/omx/entrypoint.c | 39 + 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/omx/entrypoint.c b/src/gallium/state_trackers/omx/ent