Re: [Mesa-dev] [PATCH 4/4] i965: Use safer pointer arithmetic in gather_oa_results()

2014-12-22 Thread Chad Versace
On 12/19/2014 11:58 AM, Ian Romanick wrote: > On 12/18/2014 10:14 PM, Kenneth Graunke wrote: >> On Tuesday, November 18, 2014 09:11:26 PM Chad Versace wrote: >>> This patch reduces the likelihood of pointer arithmetic overflow bugs in >>> gather_oa_results(), like the one fixed by b69c7c5dac. >>

Re: [Mesa-dev] [PATCH 4/4] i965: Use safer pointer arithmetic in gather_oa_results()

2014-12-19 Thread Ian Romanick
On 12/18/2014 10:14 PM, Kenneth Graunke wrote: > On Tuesday, November 18, 2014 09:11:26 PM Chad Versace wrote: >> This patch reduces the likelihood of pointer arithmetic overflow bugs in >> gather_oa_results(), like the one fixed by b69c7c5dac. >> >> I haven't yet encountered any overflow bugs in t

Re: [Mesa-dev] [PATCH 4/4] i965: Use safer pointer arithmetic in gather_oa_results()

2014-12-18 Thread Kenneth Graunke
On Tuesday, November 18, 2014 09:11:26 PM Chad Versace wrote: > This patch reduces the likelihood of pointer arithmetic overflow bugs in > gather_oa_results(), like the one fixed by b69c7c5dac. > > I haven't yet encountered any overflow bugs in the wild along this > patch's codepath. But I get ner

[Mesa-dev] [PATCH 4/4] i965: Use safer pointer arithmetic in gather_oa_results()

2014-11-19 Thread Chad Versace
This patch reduces the likelihood of pointer arithmetic overflow bugs in gather_oa_results(), like the one fixed by b69c7c5dac. I haven't yet encountered any overflow bugs in the wild along this patch's codepath. But I get nervous when I see code patterns like this: (void*) + (int) * (int) I

[Mesa-dev] [PATCH 4/4] i965: Use safer pointer arithmetic in gather_oa_results()

2014-11-19 Thread Chad Versace
This patch reduces the likelihood of pointer arithmetic overflow bugs in gather_oa_results(), like the one fixed by b69c7c5dac. I haven't yet encountered any overflow bugs in the wild along this patch's codepath. But I get nervous when I see code patterns like this: (void*) + (int) * (int) I