Re: [Mesa-dev] [PATCH 4/4] glsl: Delete LRP_TO_ARITH lowering pass flag.

2014-02-25 Thread Kenneth Graunke
On 02/24/2014 09:55 AM, Ian Romanick wrote: > On 02/23/2014 07:19 PM, Kenneth Graunke wrote: >> Tt's kind of a trap---calling do_common_optimization() after >> lower_instructions() may cause opt_algebraic() to reintroduce >> ir_triop_lrp expressions that were lowered, effectively defeating the >> p

Re: [Mesa-dev] [PATCH 4/4] glsl: Delete LRP_TO_ARITH lowering pass flag.

2014-02-24 Thread Ian Romanick
On 02/23/2014 07:19 PM, Kenneth Graunke wrote: Tt's kind of a trap---calling do_common_optimization() after lower_instructions() may cause opt_algebraic() to reintroduce ir_triop_lrp expressions that were lowered, effectively defeating the point. Because of this, nobody uses it. Cc: "10.1" Sig

Re: [Mesa-dev] [PATCH 4/4] glsl: Delete LRP_TO_ARITH lowering pass flag.

2014-02-23 Thread Matt Turner
Series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/4] glsl: Delete LRP_TO_ARITH lowering pass flag.

2014-02-23 Thread Kenneth Graunke
Tt's kind of a trap---calling do_common_optimization() after lower_instructions() may cause opt_algebraic() to reintroduce ir_triop_lrp expressions that were lowered, effectively defeating the point. Because of this, nobody uses it. Cc: "10.1" Signed-off-by: Kenneth Graunke --- src/glsl/ir_opt