Re: [Mesa-dev] [PATCH 36/43] st/nine: Fix multisampling support detection

2015-02-01 Thread Marek Olšák
I don't think it matters. Generally, all drivers should support mapping all formats, but some drivers can't map certain formats with more than 1 sample. Marek On Sun, Feb 1, 2015 at 8:28 PM, Axel Davy wrote: > I checked, and the application is allowed to lock the backbuffer if it > specified a

Re: [Mesa-dev] [PATCH 36/43] st/nine: Fix multisampling support detection

2015-02-01 Thread Axel Davy
I checked, and the application is allowed to lock the backbuffer if it specified a specific flag. However it seems locking a multisampled buffer is forbidden. So probably here the PIPE_BIND_TRANSFER_* flags could be removed for multisampling, should I add that behaviour ? Does it matter for s

Re: [Mesa-dev] [PATCH 36/43] st/nine: Fix multisampling support detection

2015-01-30 Thread Axel Davy
The patch modifies the code used to check for format support. It needs to test for these flags for render targets because we create the back buffers with these. Probably these flags are not required for back buffers, I'll investigate. Axel On 31/01/2015 00:36, Marek Olšák wrote : I recommen

Re: [Mesa-dev] [PATCH 36/43] st/nine: Fix multisampling support detection

2015-01-30 Thread Marek Olšák
I recommend not using PIPE_BIND_TRANSFER_READ/WRITE. Transfers with multisample textures should be supported, but the mapped texture is always a resolved single-sample copy, so it's not really an MSAA transfer. Marek On Fri, Jan 30, 2015 at 9:34 PM, Axel Davy wrote: > Signed-off-by: Axel Davy >

[Mesa-dev] [PATCH 36/43] st/nine: Fix multisampling support detection

2015-01-30 Thread Axel Davy
Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 12 +--- src/gallium/state_trackers/nine/nine_pipe.h | 25 - 2 files changed, 9 insertions(+), 28 deletions(-) diff --git a/src/gallium/state_trackers/nine/adapter9.c b/src/gallium/state_t