[Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-27 Thread Brian Paul
1. Try to choose R8G8B8A8 unorm/srgb formats before other orders in an effort to try to match component ordering for UINT/SINT/etc. 2. If we can't get a format such as PIPE_FORMAT_A16_UNORM, try PIPE_FORMAT_R16G16B16A16_UNORM before shallower formats. Reviewed-by: Marek Olšák --- src/mesa/state

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Aug 24, 2015 at 10:37 PM, Brian Paul wrote: > 1. Try to choose R8G8B8A8 unorm/srgb formats before other orders in an > effort to try to match component ordering for UINT/SINT/etc. > > 2. If we can't get a format such as PIPE_FORMAT_A16_UNORM, try > PIPE_FO

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Marek Olšák
On Tue, Aug 25, 2015 at 1:02 AM, Brian Paul wrote: > On 08/24/2015 04:34 PM, Ilia Mirkin wrote: >> >> On Mon, Aug 24, 2015 at 4:54 PM, Brian Paul wrote: Also, do the ARB_texture_view piglits still pass? They're really sensitive to the relative consistency of this stuff. >>> >>> >>>

[Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Brian Paul
1. Try to choose R8G8B8A8 unorm/srgb formats before other orders in an effort to try to match component ordering for UINT/SINT/etc. 2. If we can't get a format such as PIPE_FORMAT_A16_UNORM, try PIPE_FORMAT_R16G16B16A16_UNORM before shallower formats. --- src/mesa/state_tracker/st_format.c | 20 +

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Brian Paul
On 08/24/2015 04:34 PM, Ilia Mirkin wrote: On Mon, Aug 24, 2015 at 4:54 PM, Brian Paul wrote: Also, do the ARB_texture_view piglits still pass? They're really sensitive to the relative consistency of this stuff. Hmm, one regression in arb_texture_view-lifetime-format on llvmpipe, but not with

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Ilia Mirkin
On Mon, Aug 24, 2015 at 4:54 PM, Brian Paul wrote: >> Also, do the ARB_texture_view piglits still pass? They're really >> sensitive to the relative consistency of this stuff. > > Hmm, one regression in arb_texture_view-lifetime-format on llvmpipe, but not > with softpipe. I'll take a look. By th

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Ilia Mirkin
On Mon, Aug 24, 2015 at 4:54 PM, Brian Paul wrote: > On 08/24/2015 02:44 PM, Ilia Mirkin wrote: >> >> Not that I really care, but... why flip the order of bgra vs rgba? > > > Because if an 8-bit RGBA integer texture is created, we'll use the gallium > format PIPE_FORMAT_R8G8B8A8_SINT. If we creat

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Brian Paul
On 08/24/2015 02:44 PM, Ilia Mirkin wrote: Not that I really care, but... why flip the order of bgra vs rgba? Because if an 8-bit RGBA integer texture is created, we'll use the gallium format PIPE_FORMAT_R8G8B8A8_SINT. If we create another non-integer surface with PIPE_FORMAT_B8G8R8A8_UNORM

Re: [Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Ilia Mirkin
Not that I really care, but... why flip the order of bgra vs rgba? Also, do the ARB_texture_view piglits still pass? They're really sensitive to the relative consistency of this stuff. Note that this will really only affect glTexStorage since glTexImage is likely to hit the exact_format_* logic...

[Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Brian Paul
1. Try to choose R8G8B8A8 unorm/srgb formats before other orders in an effort to try to match component ordering for UINT/SINT/etc. 2. If we can't get a format such as PIPE_FORMAT_A16_UNORM, try PIPE_FORMAT_R16G16B16A16_UNORM before shallower formats. --- src/mesa/state_tracker/st_format.c | 20 +

[Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-24 Thread Brian Paul
1. Try to choose R8G8B8A8 unorm/srgb formats before other orders in an effort to try to match component ordering for UINT/SINT/etc. 2. If we can't get a format such as PIPE_FORMAT_A16_UNORM, try PIPE_FORMAT_R16G16B16A16_UNORM before shallower formats. --- src/mesa/state_tracker/st_format.c | 20 +