Re: [Mesa-dev] [PATCH 3/8] glsl: stop copying struct and interface member names

2017-08-09 Thread Thomas Helland
I thought I sent out a reply to this yesterday. Apparently I was too tired to remember... I was thinking a helper function to acquire the name would be nice, but there is not that many uses, so we probably should not bother. This patch is: Reviewed-by: Thomas Helland 2017-08-09 5:34 GMT+02:00 Tim

[Mesa-dev] [PATCH 3/8] glsl: stop copying struct and interface member names

2017-08-08 Thread Timothy Arceri
We are currently copying the name for each member dereference but we can just share a single instance of the string provided by the type. This change also stops us recalculating the field index repeatedly. --- src/compiler/glsl/ast_array_index.cpp | 14 - src/compiler/glsl/gl

[Mesa-dev] [PATCH 3/8] glsl: stop copying struct and interface member names

2017-08-06 Thread Timothy Arceri
We are currently copying the name for each member dereference but we can just share a single instance of the string provided by the type. This change also stops us recalculating the field index repeatedly. --- src/compiler/glsl/ast_array_index.cpp | 14 - src/compiler/glsl/gl