Re: [Mesa-dev] [PATCH 3/7] linker: Fold set_uniform_binding into call site

2014-04-10 Thread Kenneth Graunke
On 04/10/2014 11:42 AM, Ian Romanick wrote: > On 04/09/2014 08:02 AM, Kenneth Graunke wrote: >> On 04/04/2014 02:01 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> In the next patch, we'll see that using >>> gl_shader_program::UniformStorage is not correct for uniform blocks. >>> That means

Re: [Mesa-dev] [PATCH 3/7] linker: Fold set_uniform_binding into call site

2014-04-10 Thread Ian Romanick
On 04/09/2014 08:02 AM, Kenneth Graunke wrote: > On 04/04/2014 02:01 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> In the next patch, we'll see that using >> gl_shader_program::UniformStorage is not correct for uniform blocks. >> That means we can't use ::UniformStorage to select between the

Re: [Mesa-dev] [PATCH 3/7] linker: Fold set_uniform_binding into call site

2014-04-09 Thread Kenneth Graunke
On 04/04/2014 02:01 PM, Ian Romanick wrote: > From: Ian Romanick > > In the next patch, we'll see that using > gl_shader_program::UniformStorage is not correct for uniform blocks. > That means we can't use ::UniformStorage to select between the sampler > path and the block path. Instead we want

[Mesa-dev] [PATCH 3/7] linker: Fold set_uniform_binding into call site

2014-04-04 Thread Ian Romanick
From: Ian Romanick In the next patch, we'll see that using gl_shader_program::UniformStorage is not correct for uniform blocks. That means we can't use ::UniformStorage to select between the sampler path and the block path. Instead we want to just use the type of the variable. That's never pass