Re: [Mesa-dev] [PATCH 3/6] i965/vs: Convert gen6 userclip handling to new generators.

2011-08-30 Thread Paul Berry
On 28 August 2011 21:45, Eric Anholt wrote: > This DP4 had one of its operands missing, so we were generating > garbage clip distances. Using the per-opcode instruction generators > made it obvious. > IMHO, the fact that this refactor made the bug obvious speaks highly in favor of this entire p

[Mesa-dev] [PATCH 3/6] i965/vs: Convert gen6 userclip handling to new generators.

2011-08-28 Thread Eric Anholt
This DP4 had one of its operands missing, so we were generating garbage clip distances. Using the per-opcode instruction generators made it obvious. --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dr