Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Roland Scheidegger
Am 13.10.2015 um 00:26 schrieb Rob Clark: > On Mon, Oct 12, 2015 at 6:07 PM, Roland Scheidegger > wrote: >> Am 12.10.2015 um 22:37 schrieb Rob Clark: >>> On Mon, Oct 12, 2015 at 3:41 PM, Roland Scheidegger >>> wrote: Am 12.10.2015 um 20:33 schrieb Rob Clark: > On Mon, Oct 12, 2015 at 2

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Roland Scheidegger
Am 13.10.2015 um 01:01 schrieb Matt Turner: > On Mon, Oct 12, 2015 at 3:07 PM, Roland Scheidegger > wrote: >> As far as I can tell (and I could easily be wrong here...) intel hw >> doesn't have explicit conversion instruction, you just say it's a f16 >> destination. As such I believe the conversi

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Matt Turner
On Mon, Oct 12, 2015 at 3:07 PM, Roland Scheidegger wrote: > As far as I can tell (and I could easily be wrong here...) intel hw > doesn't have explicit conversion instruction, you just say it's a f16 > destination. As such I believe the conversion used would just use > ordinary rounding mode, whi

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Rob Clark
On Mon, Oct 12, 2015 at 6:07 PM, Roland Scheidegger wrote: > Am 12.10.2015 um 22:37 schrieb Rob Clark: >> On Mon, Oct 12, 2015 at 3:41 PM, Roland Scheidegger >> wrote: >>> Am 12.10.2015 um 20:33 schrieb Rob Clark: On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: > On Mon, Oct 12, 20

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Roland Scheidegger
Am 12.10.2015 um 22:37 schrieb Rob Clark: > On Mon, Oct 12, 2015 at 3:41 PM, Roland Scheidegger > wrote: >> Am 12.10.2015 um 20:33 schrieb Rob Clark: >>> On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: > On Mon, Oct 12, 2015 at 12:

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Roland Scheidegger
Am 12.10.2015 um 21:41 schrieb Roland Scheidegger: > Am 12.10.2015 um 20:33 schrieb Rob Clark: >> On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: >>> On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand wrote: >>> +/** >>> + *

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Rob Clark
On Mon, Oct 12, 2015 at 3:41 PM, Roland Scheidegger wrote: > Am 12.10.2015 um 20:33 schrieb Rob Clark: >> On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: >>> On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand wrote: >>> +/** >>

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Roland Scheidegger
Am 12.10.2015 um 20:33 schrieb Rob Clark: > On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: >> On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: >>> On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand >>> wrote: >> +/** >> + * Convert a 2-byte half float to a 4-byte float. >> + *

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Rob Clark
On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: > On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: >> On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand >> wrote: > +/** > + * Convert a 2-byte half float to a 4-byte float. > + * Based on code from: > + * http://www.openg

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Matt Turner
On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: > On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand wrote: >>> > +/** >>> > + * Convert a 2-byte half float to a 4-byte float. >>> > + * Based on code from: >>> > + * http://www.opengl.org/discussion_boards/ubb/Forum3/HTML/008786.html >>> > + */ >

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Rob Clark
On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand wrote: >> > +/** >> > + * Convert a 2-byte half float to a 4-byte float. >> > + * Based on code from: >> > + * http://www.opengl.org/discussion_boards/ubb/Forum3/HTML/008786.html >> > + */ >> > +static inline float >> > +_mesa_half_to_float(GLhalfAR

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-11 Thread Jason Ekstrand
On Oct 10, 2015 12:09 PM, "Matt Turner" wrote: > > On Sat, Oct 10, 2015 at 11:47 AM, Rob Clark wrote: > > From: Rob Clark > > > > Needed in NIR too, so move out of mesa/main/imports.c > > > > Signed-off-by: Rob Clark > > --- > > src/glsl/Makefile.am | 1 + > > src/mesa/main/imports.c

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-10 Thread Rob Clark
On Sat, Oct 10, 2015 at 3:09 PM, Matt Turner wrote: > On Sat, Oct 10, 2015 at 11:47 AM, Rob Clark wrote: >> From: Rob Clark >> >> Needed in NIR too, so move out of mesa/main/imports.c >> >> Signed-off-by: Rob Clark >> --- >> src/glsl/Makefile.am | 1 + >> src/mesa/main/imports.c | 148

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-10 Thread Matt Turner
On Sat, Oct 10, 2015 at 11:47 AM, Rob Clark wrote: > From: Rob Clark > > Needed in NIR too, so move out of mesa/main/imports.c > > Signed-off-by: Rob Clark > --- > src/glsl/Makefile.am | 1 + > src/mesa/main/imports.c | 148 -- > src/mesa/main/import

[Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-10 Thread Rob Clark
From: Rob Clark Needed in NIR too, so move out of mesa/main/imports.c Signed-off-by: Rob Clark --- src/glsl/Makefile.am | 1 + src/mesa/main/imports.c | 148 -- src/mesa/main/imports.h | 38 -- src/util/Makefile.sources | 2 + src/util/