Re: [Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

2015-12-14 Thread Ilia Mirkin
On Mon, Dec 14, 2015 at 11:02 AM, Samuel Pitoiset wrote: > > > On 12/14/2015 04:04 PM, Ilia Mirkin wrote: >> >> Instead take the return value and stick it into the if below. >> Returning early from these functions isn't something we generally want >> to do. > > > We already return at the same poin

Re: [Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

2015-12-14 Thread Samuel Pitoiset
On 12/14/2015 04:04 PM, Ilia Mirkin wrote: Instead take the return value and stick it into the if below. Returning early from these functions isn't something we generally want to do. We already return at the same point for vertex programs, but I can definitely move this below. On Mon, De

Re: [Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

2015-12-14 Thread Ilia Mirkin
Instead take the return value and stick it into the if below. Returning early from these functions isn't something we generally want to do. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/

[Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

2015-12-14 Thread Samuel Pitoiset
Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c b/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c inde