Re: [Mesa-dev] [PATCH 3/5] mesa/meta: Add support for storing the current read buffer

2014-08-01 Thread Jason Ekstrand
On Fri, Aug 1, 2014 at 6:44 AM, Neil Roberts wrote: > Is this patch necessary? I think the read buffer is part of the > framebuffer state so any meta function that binds its own framebuffer > won't need to save the read buffer, right? This is the case for > _mesa_meta_CopyImageSubData_uncompresse

Re: [Mesa-dev] [PATCH 3/5] mesa/meta: Add support for storing the current read buffer

2014-08-01 Thread Neil Roberts
Is this patch necessary? I think the read buffer is part of the framebuffer state so any meta function that binds its own framebuffer won't need to save the read buffer, right? This is the case for _mesa_meta_CopyImageSubData_uncompressed which binds both a read and write FBO so I think it shouldn'

[Mesa-dev] [PATCH 3/5] mesa/meta: Add support for storing the current read buffer

2014-07-31 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/mesa/drivers/common/meta.c | 13 + src/mesa/drivers/common/meta.h | 4 src/mesa/drivers/common/meta_blit.c | 3 ++- 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/c