On Mon, Nov 4, 2013 at 11:30 AM, Paul Berry wrote:
> On 4 November 2013 11:23, Matt Turner wrote:
>>
>> On Mon, Nov 4, 2013 at 10:57 AM, Paul Berry
>> wrote:
>> > On 4 November 2013 10:31, Eric Anholt wrote:
>> >>
>> >> Matt Turner writes:
>> >> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_
On 4 November 2013 11:23, Matt Turner wrote:
> On Mon, Nov 4, 2013 at 10:57 AM, Paul Berry
> wrote:
> > On 4 November 2013 10:31, Eric Anholt wrote:
> >>
> >> Matt Turner writes:
> >> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp
> >> > b/src/mesa/drivers/dri/i965/brw_fs_sel
On Mon, Nov 4, 2013 at 10:57 AM, Paul Berry wrote:
> On 4 November 2013 10:31, Eric Anholt wrote:
>>
>> Matt Turner writes:
>> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp
>> > b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp
>> > new file mode 100644
>> > index 000..9
On 4 November 2013 10:31, Eric Anholt wrote:
> Matt Turner writes:
> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp
> > new file mode 100644
> > index 000..9626751
> > --- /dev/null
> > +++ b/src/mesa/drivers/dri/i965/br
Matt Turner writes:
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp
> new file mode 100644
> index 000..9626751
> --- /dev/null
> +++ b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp
> +bool
> +fs_visitor::opt_peephole
On Fri, Nov 1, 2013 at 3:02 PM, Paul Berry wrote:
> In the last round of review, you gave me some nice clarification on why this
> was chosen to be 8. Would you mind documenting that in the comment?
Yes, I will add it.
Thanks Paul!
___
mesa-dev mailin
On 31 October 2013 18:57, Matt Turner wrote:
> fs_visitor::try_replace_with_sel optimizes only if statements whose
> "then" and "else" bodies contain a single MOV instruction. It also
> could not handle constant arguments, since they cause an extra MOV
> immediate to be generated (since we haven'
fs_visitor::try_replace_with_sel optimizes only if statements whose
"then" and "else" bodies contain a single MOV instruction. It also
could not handle constant arguments, since they cause an extra MOV
immediate to be generated (since we haven't run constant propagation,
there are more than the sin
