Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-21 Thread Tomasz Figa
Hi Emil, On Mon, Aug 20, 2018 at 10:47 PM Emil Velikov wrote: > > On 13 August 2018 at 17:18, Tomasz Figa wrote: > > On Tue, Aug 14, 2018 at 1:09 AM Emil Velikov > > wrote: > >> > >> On 13 August 2018 at 16:43, Tomasz Figa wrote: > >> > On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov > >> > w

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-20 Thread Emil Velikov
On 13 August 2018 at 17:18, Tomasz Figa wrote: > On Tue, Aug 14, 2018 at 1:09 AM Emil Velikov wrote: >> >> On 13 August 2018 at 16:43, Tomasz Figa wrote: >> > On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov >> > wrote: >> >> >> >> On 13 August 2018 at 16:16, Tomasz Figa wrote: >> >> > Hi Emil,

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Tomasz Figa
On Tue, Aug 14, 2018 at 1:09 AM Emil Velikov wrote: > > On 13 August 2018 at 16:43, Tomasz Figa wrote: > > On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov > > wrote: > >> > >> On 13 August 2018 at 16:16, Tomasz Figa wrote: > >> > Hi Emil, > >> > > >> > On Mon, Aug 13, 2018 at 11:48 PM Emil Velik

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Emil Velikov
On 13 August 2018 at 16:43, Tomasz Figa wrote: > On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov > wrote: >> >> On 13 August 2018 at 16:16, Tomasz Figa wrote: >> > Hi Emil, >> > >> > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov >> > wrote: >> >> >> >> From: Emil Velikov >> >> >> >> The functi

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Tomasz Figa
On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov wrote: > > On 13 August 2018 at 16:16, Tomasz Figa wrote: > > Hi Emil, > > > > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov > > wrote: > >> > >> From: Emil Velikov > >> > >> The function name is misleading - it effectively checks if > >> loader_ge

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Emil Velikov
On 13 August 2018 at 16:16, Tomasz Figa wrote: > Hi Emil, > > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov > wrote: >> >> From: Emil Velikov >> >> The function name is misleading - it effectively checks if >> loader_get_driver_for_fd fails. Which can happen only only on strdup >> error - a clo

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Tomasz Figa
Hi Emil, On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov wrote: > > From: Emil Velikov > > The function name is misleading - it effectively checks if > loader_get_driver_for_fd fails. Which can happen only only on strdup > error - a close to impossible scenario. How about a DRI node which doesn't

[Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

2018-08-13 Thread Emil Velikov
From: Emil Velikov The function name is misleading - it effectively checks if loader_get_driver_for_fd fails. Which can happen only only on strdup error - a close to impossible scenario. Drop the function - we call the loader API at at later stage. Cc: Robert Foss Cc: Tomasz Figa Signed-off-b