[Mesa-dev] [PATCH 3/4] vbo: Rework checking of 'end' against _MaxElement.

2012-02-16 Thread Kenneth Graunke
This failed to take basevertex into account: If basevertex < 0: (end + basevertex) might actually be in-bounds while 'end' is not. We would have clamped in this case when we probably shouldn't. This could break application drawing. If basevertex > 0: 'end' might be in-bounds while (en

Re: [Mesa-dev] [PATCH 3/4] vbo: Rework checking of 'end' against _MaxElement.

2012-02-08 Thread Roland Scheidegger
Am 08.02.2012 14:08, schrieb Kenneth Graunke: > This failed to take basevertex into account: > > If basevertex < 0: >(end + basevertex) might actually be in-bounds while 'end' is not. >We would have clamped in this case when we probably shouldn't. >This could break application drawing.

Re: [Mesa-dev] [PATCH 3/4] vbo: Rework checking of 'end' against _MaxElement.

2012-02-08 Thread Brian Paul
On 02/08/2012 06:08 AM, Kenneth Graunke wrote: This failed to take basevertex into account: If basevertex< 0: (end + basevertex) might actually be in-bounds while 'end' is not. We would have clamped in this case when we probably shouldn't. This could break application drawing. If b

[Mesa-dev] [PATCH 3/4] vbo: Rework checking of 'end' against _MaxElement.

2012-02-08 Thread Kenneth Graunke
This failed to take basevertex into account: If basevertex < 0: (end + basevertex) might actually be in-bounds while 'end' is not. We would have clamped in this case when we probably shouldn't. This could break application drawing. If basevertex > 0: 'end' might be in-bounds while (en