Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-08-08 Thread Mathias Fröhlich
Hi, On Friday, August 07, 2015 12:17:15 Ilia Mirkin wrote: > None of the other drivers appear to do it... should be safe. I'll def test > it out before pushing, of course... I've been meaning to plug a nv1x in so > I can play with a couple of minor items. Ideally it'd switch to the i965 > method,

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-08-07 Thread Ilia Mirkin
On Fri, Aug 7, 2015 at 12:03 PM, Mathias Fröhlich wrote: > > > Ilia, > > > > On Friday, August 07, 2015 11:20:42 Ilia Mirkin wrote: > > > Yeah, I tend to agree with you -- it seems like _tnl_wakeup is meant for > > > "oh hey, I shut you down and haven't been sending you updates, but I want > > >

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-08-07 Thread Mathias Fröhlich
Ilia, On Friday, August 07, 2015 11:20:42 Ilia Mirkin wrote: > Yeah, I tend to agree with you -- it seems like _tnl_wakeup is meant for > "oh hey, I shut you down and haven't been sending you updates, but I want > to use you again, so please update your stuff to match reality". Does it > even need

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-08-07 Thread Brian Paul
On 08/07/2015 08:28 AM, Ilia Mirkin wrote: On Fri, Aug 7, 2015 at 2:46 AM, Mathias Fröhlich mailto:mathias.froehl...@gmx.net>> wrote: __ Hi, On Thursday, August 06, 2015 12:32:18 Ilia Mirkin wrote: > > @@ -182,6 +187,13 @@ _tnl_InvalidateState( struct gl_context *ctx, GLuint

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-08-07 Thread Ilia Mirkin
On Fri, Aug 7, 2015 at 11:07 AM, Mathias Fröhlich wrote: > > > Hi, > > > > On Friday, August 07, 2015 10:28:10 Ilia Mirkin wrote: > > > > One alternative I can see is to call _tnl_InvalidateState without the > > > > _NEW_VIEWPORT and > > > > > > > > _NEW_BUFFERS flag set instead of _tnl_wakeup in

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-08-07 Thread Mathias Fröhlich
Hi, On Friday, August 07, 2015 10:28:10 Ilia Mirkin wrote: > > One alternative I can see is to call _tnl_InvalidateState without the > > _NEW_VIEWPORT and > > > > _NEW_BUFFERS flag set instead of _tnl_wakeup in the two nouveau early > > initialization > > > > code paths in nouveau_swtnl_t.c and nv

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-08-07 Thread Ilia Mirkin
On Fri, Aug 7, 2015 at 2:46 AM, Mathias Fröhlich wrote: > > > Hi, > > > > On Thursday, August 06, 2015 12:32:18 Ilia Mirkin wrote: > > > > @@ -182,6 +187,13 @@ _tnl_InvalidateState( struct gl_context *ctx, > GLuint new_state ) > > > > } > > > > } > > > > } > > > > + > > > > + if (new_state & (_NE

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-08-06 Thread Mathias Fröhlich
Hi, On Thursday, August 06, 2015 12:32:18 Ilia Mirkin wrote: > > @@ -182,6 +187,13 @@ _tnl_InvalidateState( struct gl_context *ctx, GLuint > > new_state ) > > } > >} > > } > > + > > + if (new_state & (_NEW_VIEWPORT | _NEW_BUFFERS)) { > > + double scale[3], translate[3

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-08-06 Thread Ilia Mirkin
On Thu, Apr 2, 2015 at 12:30 PM, wrote: > From: Mathias Froehlich > > Hi Brian, > > Thanks for the review! > The Patch with unneeded parentheses removed. > Ok, to push? > > Greetings > > Mathias > > > This is the only real user of _WindowMap which has the depth > buffer scaling multiplied in. Ma

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-04-04 Thread Mathias Fröhlich
Hi Brian, > > The Patch with unneeded parentheses removed. > > Ok, to push? > > > > Yes. Just pushed, thanks again for the review! Mathias ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-04-02 Thread Brian Paul
On Thu, Apr 2, 2015 at 10:30 AM, wrote: > From: Mathias Froehlich > > Hi Brian, > > Thanks for the review! > The Patch with unneeded parentheses removed. > Ok, to push? > Yes. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lis

[Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-04-02 Thread Mathias . Froehlich
From: Mathias Froehlich Hi Brian, Thanks for the review! The Patch with unneeded parentheses removed. Ok, to push? Greetings Mathias This is the only real user of _WindowMap which has the depth buffer scaling multiplied in. Maintain the _WindowMap of the one and only viewport inside TNLconte

Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext.

2015-03-31 Thread Brian Paul
On 03/31/2015 12:37 AM, mathias.froehl...@gmx.net wrote: From: Mathias Froehlich This is the only real user of _WindowMap which has the depth buffer scaling multiplied in. Maintain the _WindowMap of the one and only viewport inside TNLcontext. Signed-off-by: Mathias Froehlich --- src/mesa/s

[Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext.

2015-03-30 Thread Mathias . Froehlich
From: Mathias Froehlich This is the only real user of _WindowMap which has the depth buffer scaling multiplied in. Maintain the _WindowMap of the one and only viewport inside TNLcontext. Signed-off-by: Mathias Froehlich --- src/mesa/swrast_setup/ss_context.c | 5 +++-- src/mesa/tnl/t_context.