Re: [Mesa-dev] [PATCH 3/4] r600/radeonsi: implement new float comparison instructions

2014-11-23 Thread Roland Scheidegger
Am 23.11.2014 um 22:34 schrieb Marek Olšák: > Hi Roland, > > What's the reason for not using an ordered comparison for SNE? Well, I guess for consistency with the new Fxxx versions (essentially dx10). All ordered except not equal which is unordered (I have no idea if that's what the r600 does with

Re: [Mesa-dev] [PATCH 3/4] r600/radeonsi: implement new float comparison instructions

2014-11-23 Thread Marek Olšák
Hi Roland, What's the reason for not using an ordered comparison for SNE? Marek On Tue, Aug 13, 2013 at 7:04 PM, wrote: > From: Roland Scheidegger > > Also use ordered comparisons for old cmp instructions. Untested. > --- > src/gallium/drivers/r600/r600_shader.c | 18 --- >

Re: [Mesa-dev] [PATCH 3/4] r600/radeonsi: implement new float comparison instructions

2013-08-14 Thread Michel Dänzer
On Die, 2013-08-13 at 19:39 -0700, Tom Stellard wrote: > On Tue, Aug 13, 2013 at 07:04:56PM +0200, srol...@vmware.com wrote: > > From: Roland Scheidegger > > > > Also use ordered comparisons for old cmp instructions. Untested. > > This patch looks good to me, but I would like to do a piglit run

Re: [Mesa-dev] [PATCH 3/4] r600/radeonsi: implement new float comparison instructions

2013-08-13 Thread Tom Stellard
On Tue, Aug 13, 2013 at 07:04:56PM +0200, srol...@vmware.com wrote: > From: Roland Scheidegger > > Also use ordered comparisons for old cmp instructions. Untested. This patch looks good to me, but I would like to do a piglit run on radeonsi before you commit. I will try to do this tomorrow. -T

[Mesa-dev] [PATCH 3/4] r600/radeonsi: implement new float comparison instructions

2013-08-13 Thread sroland
From: Roland Scheidegger Also use ordered comparisons for old cmp instructions. Untested. --- src/gallium/drivers/r600/r600_shader.c | 18 --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 49 2 files changed, 48 insertions(+), 19 deletions(-) dif