Re: [Mesa-dev] [PATCH 3/4] mesa: Don't call driver RenderTexture for invalid zoffset

2013-07-28 Thread Ian Romanick
On 07/28/2013 03:32 PM, Chris Forbes wrote: + if (att->Zoffset > texImage->Depth) Shouldn't this be >=, same as in your later array patch? Yes. Good catch. Off-by-one error for the lose. :( -- Chris ___ mesa-dev mailing list mesa-dev@lists.f

Re: [Mesa-dev] [PATCH 3/4] mesa: Don't call driver RenderTexture for invalid zoffset

2013-07-28 Thread Chris Forbes
+ if (att->Zoffset > texImage->Depth) Shouldn't this be >=, same as in your later array patch? -- Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/4] mesa: Don't call driver RenderTexture for invalid zoffset

2013-07-28 Thread Ian Romanick
From: Ian Romanick This fixes the segfault in the 'invalid slice of 3D texture' and 'invalid layer of an array texture' subtests of piglit's fbo-incomplete test. The 'invalid layer of an array texture' subtest still fails. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org ---