Re: [Mesa-dev] [PATCH 3/4] intel: Unobfuscate intel_alloc_renderbuffer_storage

2011-06-20 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sun, 19 Jun 2011 02:56:51 -0700, Kenneth Graunke wrote: > On 06/17/2011 03:43 PM, Chad Versace wrote: > > Hiz buffer allocation can only occur if the 'else' branch has been taken, > > so move the hiz buffer allocation into the 'else' branch. > > >

Re: [Mesa-dev] [PATCH 3/4] intel: Unobfuscate intel_alloc_renderbuffer_storage

2011-06-19 Thread Kenneth Graunke
On 06/19/2011 03:27 PM, Chad Versace wrote: [snip] Yes. I neglected to duplicate that the (!irb->region) check in the S8 case. I'll add it to the patch. But, "leaving that check below" is no longer possible due to patch 4 --- !irb->region is always false for the wrapped S8_Z24 case. So the check

Re: [Mesa-dev] [PATCH 3/4] intel: Unobfuscate intel_alloc_renderbuffer_storage

2011-06-19 Thread Chad Versace
On Sun, 19 Jun 2011 02:56:51 -0700, Kenneth Graunke wrote: > On 06/17/2011 03:43 PM, Chad Versace wrote: > > Hiz buffer allocation can only occur if the 'else' branch has been taken, > > so move the hiz buffer allocation into the 'else' branch. > > > > Having the hiz buffer allocation dangling ou

Re: [Mesa-dev] [PATCH 3/4] intel: Unobfuscate intel_alloc_renderbuffer_storage

2011-06-19 Thread Kenneth Graunke
On 06/17/2011 03:43 PM, Chad Versace wrote: Hiz buffer allocation can only occur if the 'else' branch has been taken, so move the hiz buffer allocation into the 'else' branch. Having the hiz buffer allocation dangling outside of the if-tree was just damn confusing. Signed-off-by: Chad Versace -

[Mesa-dev] [PATCH 3/4] intel: Unobfuscate intel_alloc_renderbuffer_storage

2011-06-17 Thread Chad Versace
Hiz buffer allocation can only occur if the 'else' branch has been taken, so move the hiz buffer allocation into the 'else' branch. Having the hiz buffer allocation dangling outside of the if-tree was just damn confusing. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/intel/intel_fbo.c |