Ah, now that I looked at your other patch I see why you have image_height.
On Wed, Feb 25, 2015 at 5:33 PM, Laura Ekstrand
wrote:
> This was an unfortunate artifact of rebasing; I fixed the 1D array bug
> before figuring out a robust fix for the 2D array bug (7a49f2e). I think
> that you are ri
This was an unfortunate artifact of rebasing; I fixed the 1D array bug
before figuring out a robust fix for the 2D array bug (7a49f2e). I think
that you are right, although I'm confused what you are doing with the
variable image_height that you added. It seems like you should be able to
get rid o
Sorry for the late review.
Can you explain what this patch does? The previous code was doing a blit
like this:
_mesa_meta_BlitFramebuffer(ctx, ctx->ReadBuffer, ctx->DrawBuffer,
0, z * height, width, (z + 1) * height,
xoffset,
Corrects the way that _mesa_meta_pbo_TexSubImage and
_mesa_meta_pbo_GetTexSubImage handle 1D_ARRAY textures. Fixes a failure in
the Piglit arb_direct_state_access/gettextureimage-targets test.
---
src/mesa/drivers/common/meta_tex_subimage.c | 62 +
1 file changed, 36 i
