[Mesa-dev] [PATCH 3/3] radeonsi: cleanup si_db()

2012-11-15 Thread alexdeucher
From: Alex Deucher Clean up a few magic numbers and rework the code a bit. Signed-off-by: Alex Deucher Reviewed-by: Christian König Reviewed-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_state.c | 22 ++ src/gallium/drivers/radeonsi/sid.h |2 ++ 2 files

[Mesa-dev] [PATCH 3/3] radeonsi: cleanup si_db()

2012-11-15 Thread alexdeucher
From: Alex Deucher Clean up a few magic numbers and rework the code a bit. Signed-off-by: Alex Deucher Reviewed-by: Christian König Reviewed-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_state.c | 22 ++ src/gallium/drivers/radeonsi/sid.h |2 ++ 2 files

Re: [Mesa-dev] [PATCH 3/3] radeonsi: cleanup si_db()

2012-11-15 Thread Alex Deucher
On Thu, Nov 15, 2012 at 8:46 AM, Michel Dänzer wrote: > On Mit, 2012-11-14 at 14:14 -0500, alexdeuc...@gmail.com wrote: >> From: Alex Deucher >> >> Clean up a few magic numbers and rework the code a bit. >> >> Signed-off-by: Alex Deucher > > Reviewed-by: Michel Dänzer > > I agree with Marek's c

Re: [Mesa-dev] [PATCH 3/3] radeonsi: cleanup si_db()

2012-11-15 Thread Michel Dänzer
On Mit, 2012-11-14 at 14:14 -0500, alexdeuc...@gmail.com wrote: > From: Alex Deucher > > Clean up a few magic numbers and rework the code a bit. > > Signed-off-by: Alex Deucher Reviewed-by: Michel Dänzer I agree with Marek's comments on patches 1-2, also there are some typos in the commit l

[Mesa-dev] [PATCH 3/3] radeonsi: cleanup si_db()

2012-11-14 Thread alexdeucher
From: Alex Deucher Clean up a few magic numbers and rework the code a bit. Signed-off-by: Alex Deucher --- src/gallium/drivers/radeonsi/si_state.c | 22 ++ src/gallium/drivers/radeonsi/sid.h |2 ++ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/