Re: [Mesa-dev] [PATCH 3/3] r600, compute: Plug couple of memory leaks

2015-06-05 Thread Marek Olšák
On Fri, Jun 5, 2015 at 5:02 PM, Jan Vesely wrote: > sorry for the delay, I'm just getting settled. > > On Tue, 2015-05-26 at 11:29 +0200, Marek Olšák wrote: >> The new functions in gallium/radeon shouldn't be inline, because >> inlining them isn't critical for performance. > > should I avoid heade

Re: [Mesa-dev] [PATCH 3/3] r600, compute: Plug couple of memory leaks

2015-06-05 Thread Jan Vesely
sorry for the delay, I'm just getting settled. On Tue, 2015-05-26 at 11:29 +0200, Marek Olšák wrote: > The new functions in gallium/radeon shouldn't be inline, because > inlining them isn't critical for performance. should I avoid header definitions entirely, or are static (not inline) functions

Re: [Mesa-dev] [PATCH 3/3] r600, compute: Plug couple of memory leaks

2015-05-26 Thread Marek Olšák
The new functions in gallium/radeon shouldn't be inline, because inlining them isn't critical for performance. Also, I don't see a point in functions that only contain one line. Especially radeon_llvm_dispose_kernel_module looks like an unnecessary wrapper. Marek On Tue, May 26, 2015 at 2:05 AM,

[Mesa-dev] [PATCH 3/3] r600,compute: Plug couple of memory leaks

2015-05-25 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/drivers/r600/evergreen_compute.c | 24 +--- src/gallium/drivers/r600/r600_llvm.c | 14 +- src/gallium/drivers/r600/r600_llvm.h | 2 ++ src/gallium/drivers/radeon/r600_pipe_common.h | 17 +