Re: [Mesa-dev] [PATCH 3/3] nvc0: refactor textures/samplers validation

2016-11-09 Thread Samuel Pitoiset
On 11/07/2016 04:30 AM, Ilia Mirkin wrote: Patches 1-2 seem OK. I'm a little concerned that this one is changing functionality, since it's removing the "need_flush" thing. It'd be nice if you could get this patch some heavier testing before pushing it out... No regressions with piglit on GF10

Re: [Mesa-dev] [PATCH 3/3] nvc0: refactor textures/samplers validation

2016-11-07 Thread Samuel Pitoiset
On 11/07/2016 04:30 AM, Ilia Mirkin wrote: Patches 1-2 seem OK. I'm a little concerned that this one is changing functionality, since it's removing the "need_flush" thing. It'd be nice if you could get this patch some heavier testing before pushing it out... Yes, it's more fine-grained textur

Re: [Mesa-dev] [PATCH 3/3] nvc0: refactor textures/samplers validation

2016-11-06 Thread Ilia Mirkin
Patches 1-2 seem OK. I'm a little concerned that this one is changing functionality, since it's removing the "need_flush" thing. It'd be nice if you could get this patch some heavier testing before pushing it out... On Wed, Oct 26, 2016 at 4:00 PM, Samuel Pitoiset wrote: > The first goal is to re

[Mesa-dev] [PATCH 3/3] nvc0: refactor textures/samplers validation

2016-10-26 Thread Samuel Pitoiset
The first goal is to reduce code duplication between 3d and compute and increase readability of that area. This refactoring also tries to reduce the number of commands send through the pushbuffer and to not invalidate all caches when binding new textures/samplers. Although I don't see any improvem