Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

2015-09-21 Thread Emil Velikov
On 19 September 2015 at 14:53, Jason Ekstrand wrote: > On Sat, Sep 19, 2015 at 1:28 AM, Jonathan Gray wrote: >> On Fri, Sep 18, 2015 at 10:52:35AM -0700, Jason Ekstrand wrote: >>> On Sep 18, 2015 12:40 PM, "Emil Velikov" wrote: >>> > >>> > Thanks for the review/testing guys. >>> > >>> > Just not

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

2015-09-19 Thread Jason Ekstrand
On Sat, Sep 19, 2015 at 1:28 AM, Jonathan Gray wrote: > On Fri, Sep 18, 2015 at 10:52:35AM -0700, Jason Ekstrand wrote: >> On Sep 18, 2015 12:40 PM, "Emil Velikov" wrote: >> > >> > Thanks for the review/testing guys. >> > >> > Just noticed that some typos/strange wording >> > >> > On 17 September

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

2015-09-19 Thread Emil Velikov
Hi Jason, On 18 September 2015 at 18:52, Jason Ekstrand wrote: > > On Sep 18, 2015 12:40 PM, "Emil Velikov" wrote: >> >> Thanks for the review/testing guys. >> >> Just noticed that some typos/strange wording >> >> On 17 September 2015 at 16:25, Emil Velikov >> wrote: >> > With the only C++ func

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

2015-09-19 Thread Jonathan Gray
On Fri, Sep 18, 2015 at 10:52:35AM -0700, Jason Ekstrand wrote: > On Sep 18, 2015 12:40 PM, "Emil Velikov" wrote: > > > > Thanks for the review/testing guys. > > > > Just noticed that some typos/strange wording > > > > On 17 September 2015 at 16:25, Emil Velikov > wrote: > > > With the only C++ f

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

2015-09-18 Thread Jason Ekstrand
On Sep 18, 2015 12:40 PM, "Emil Velikov" wrote: > > Thanks for the review/testing guys. > > Just noticed that some typos/strange wording > > On 17 September 2015 at 16:25, Emil Velikov wrote: > > With the only C++ function having it's own wrapper we can 'demote' this > s/it's/its/ > > > file to a

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

2015-09-18 Thread Emil Velikov
Thanks for the review/testing guys. Just noticed that some typos/strange wording On 17 September 2015 at 16:25, Emil Velikov wrote: > With the only C++ function having it's own wrapper we can 'demote' this s/it's/its/ > file to a normal C one. This allows us to get rid of extern C { > support C

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

2015-09-17 Thread Timothy Arceri
On Thu, 2015-09-17 at 16:25 +0100, Emil Velikov wrote: > With the only C++ function having it's own wrapper we can 'demote' > this > file to a normal C one. This allows us to get rid of extern C { > support C99 designated initializers in CPP code. > > This may cause build issue due to the missing

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

2015-09-17 Thread Gottfried Haider
Patches 1-3 Tested-by: Gottfried Haider Thanks! On Thu, Sep 17, 2015 at 5:25 PM, Emil Velikov wrote: > With the only C++ function having it's own wrapper we can 'demote' this > file to a normal C one. This allows us to get rid of extern C { > support C99 designated initializers in CPP code. > >

[Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

2015-09-17 Thread Emil Velikov
With the only C++ function having it's own wrapper we can 'demote' this file to a normal C one. This allows us to get rid of extern C { support C99 designated initializers in CPP code. This may cause build issue due to the missing dependency. If doing incremental build run the following: sed -i -