Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-08 Thread Neil Roberts
This seems like a nice solution to me. I just have a small comment below. > -static struct gl_shader_program_data * > -create_shader_program_data() > +struct gl_shader_program_data * > +_mesa_create_shader_program_data() > { > struct gl_shader_program_data *data; > data = rzalloc(NULL, st

Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Tapani Pälli
On 11/08/2017 08:59 AM, Timothy Arceri wrote: On 08/11/17 16:58, Tapani Pälli wrote: One question below ... On 11/08/2017 03:41 AM, Timothy Arceri wrote: When I introduced gl_shader_program_data one of the intentions was to fix a bug where a failed linking attempt freed data required by a

Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Timothy Arceri
On 08/11/17 16:58, Tapani Pälli wrote: One question below ... On 11/08/2017 03:41 AM, Timothy Arceri wrote: When I introduced gl_shader_program_data one of the intentions was to fix a bug where a failed linking attempt freed data required by a currently active program. However I seem to have

Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Timothy Arceri
On 08/11/17 16:53, Kenneth Graunke wrote: On Tuesday, November 7, 2017 5:41:59 PM PST Timothy Arceri wrote: When I introduced gl_shader_program_data one of the intentions was to fix a bug where a failed linking attempt freed data required by a currently active program. However I seem to have fai

Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Tapani Pälli
One question below ... On 11/08/2017 03:41 AM, Timothy Arceri wrote: When I introduced gl_shader_program_data one of the intentions was to fix a bug where a failed linking attempt freed data required by a currently active program. However I seem to have failed to finish hooking up the final step

Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Kenneth Graunke
On Tuesday, November 7, 2017 5:41:59 PM PST Timothy Arceri wrote: > When I introduced gl_shader_program_data one of the intentions was to > fix a bug where a failed linking attempt freed data required by a > currently active program. However I seem to have failed to finish > hooking up the final st

[Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Timothy Arceri
When I introduced gl_shader_program_data one of the intentions was to fix a bug where a failed linking attempt freed data required by a currently active program. However I seem to have failed to finish hooking up the final steps required to have the data hang around. Here we create a fresh instanc