Hi Eric,
Thanks for the review.
I will send shortly an updated patch.
... except:
On Friday, December 30, 2011 12:13:36 Eric Anholt wrote:
> Also, I think that helper would be easier to read as;
>
> + GLbitfield64 enabled = arrayObj->_Enabled;
> +
> + if (enabled & VERT_ATTRIB_GENERIC0)
>
On Thu, 29 Dec 2011 23:14:25 +0100, Mathias Fröhlich
wrote:
> Use a bitmask approach to compute gl_array_object::_MaxElement.
> To make this work reliably depending on the shader type actually used,
> make use of the newly introduced typed bitmaks getters.
> With this change I gain about 5% draw
Use a bitmask approach to compute gl_array_object::_MaxElement.
To make this work reliably depending on the shader type actually used,
make use of the newly introduced typed bitmaks getters.
With this change I gain about 5% draw time on some osgviewer examples.
Signed-off-by: Mathias Fröhlich
---
