Re: [Mesa-dev] [PATCH 3/3] intel/decoder: Fix is_header_field starting condition.

2017-04-12 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 12/04/17 23:33, Kenneth Graunke wrote: Starting positions >= 32 are not part of the header, rather than >. Caught by Coverity, which found that "bits <<= field->start" may shift by 32, which has undefined behavior. CID: 1404968 --- src/intel/common/gen_deco

[Mesa-dev] [PATCH 3/3] intel/decoder: Fix is_header_field starting condition.

2017-04-12 Thread Kenneth Graunke
Starting positions >= 32 are not part of the header, rather than >. Caught by Coverity, which found that "bits <<= field->start" may shift by 32, which has undefined behavior. CID: 1404968 --- src/intel/common/gen_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/