Re: [Mesa-dev] [PATCH 3/3] gallium/u_gen_mipmap: rewrite using pipe->blit

2014-03-26 Thread Marek Olšák
I'm going to add parameters: format, first_layer, last_layer. I'm going to drop: face. Marek On Thu, Mar 27, 2014 at 1:22 AM, Roland Scheidegger wrote: > Marek, > > what are your plans for this change? > > Roland > > Am 22.03.2014 20:03, schrieb Roland Scheidegger: >>> On Sat, Mar 22, 2014 at 4:

Re: [Mesa-dev] [PATCH 3/3] gallium/u_gen_mipmap: rewrite using pipe->blit

2014-03-26 Thread Roland Scheidegger
Marek, what are your plans for this change? Roland Am 22.03.2014 20:03, schrieb Roland Scheidegger: >> On Sat, Mar 22, 2014 at 4:54 PM, Roland Scheidegger >> wrote: >>> I think this is missing some parameters by not using a sampler view. In >>> particular can we please have a separate format he

Re: [Mesa-dev] [PATCH 3/3] gallium/u_gen_mipmap: rewrite using pipe->blit

2014-03-22 Thread Roland Scheidegger
> On Sat, Mar 22, 2014 at 4:54 PM, Roland Scheidegger > wrote: > > I think this is missing some parameters by not using a sampler view. In > > particular can we please have a separate format here? It may not matter > > for GL (srgb maybe, texture views?), but for this to work with d3d we > > need

Re: [Mesa-dev] [PATCH 3/3] gallium/u_gen_mipmap: rewrite using pipe->blit

2014-03-22 Thread Marek Olšák
On Sat, Mar 22, 2014 at 4:54 PM, Roland Scheidegger wrote: > I think this is missing some parameters by not using a sampler view. In > particular can we please have a separate format here? It may not matter > for GL (srgb maybe, texture views?), but for this to work with d3d we > need to be able t

Re: [Mesa-dev] [PATCH 3/3] gallium/u_gen_mipmap: rewrite using pipe->blit

2014-03-22 Thread Roland Scheidegger
Am 22.03.2014 16:54, schrieb Roland Scheidegger: > Am 16.03.2014 15:47, schrieb Marek Olšák: >> From: Marek Olšák >> >> This replaces u_gen_mipmap with an extremely simple implementation based >> on pipe->blit. The diff speaks for itself. st/mesa is also cleaned up. >> >> Pros: >> - less code >> -

Re: [Mesa-dev] [PATCH 3/3] gallium/u_gen_mipmap: rewrite using pipe->blit

2014-03-22 Thread Roland Scheidegger
Am 16.03.2014 15:47, schrieb Marek Olšák: > From: Marek Olšák > > This replaces u_gen_mipmap with an extremely simple implementation based > on pipe->blit. The diff speaks for itself. st/mesa is also cleaned up. > > Pros: > - less code > - correct mipmap generation for NPOT 3D textures (u_blitte

[Mesa-dev] [PATCH 3/3] gallium/u_gen_mipmap: rewrite using pipe->blit

2014-03-16 Thread Marek Olšák
From: Marek Olšák This replaces u_gen_mipmap with an extremely simple implementation based on pipe->blit. The diff speaks for itself. st/mesa is also cleaned up. Pros: - less code - correct mipmap generation for NPOT 3D textures (u_blitter uses a better formula) - queries are not affected by m