Re: [Mesa-dev] [PATCH 3/3] draw: fix problem in screen-space interpolation clip code

2013-01-21 Thread Jose Fonseca
Series looks good to me. Reviewed-by: Brian Paul Jose - Original Message - > I don't see how this could have ever worked right. > > The screen-space interpolation code uses the vertex->data[pos_attr] > position which contain window coords. But window coords are only > computed for the

[Mesa-dev] [PATCH 3/3] draw: fix problem in screen-space interpolation clip code

2013-01-21 Thread Brian Paul
I don't see how this could have ever worked right. The screen-space interpolation code uses the vertex->data[pos_attr] position which contain window coords. But window coords are only computed for the unclipped vertices; the clipped vertices have undefined window coords (see draw_cliptest_tmp.h).