Re: [Mesa-dev] [PATCH 20/26] python: Open file in binary mode

2018-07-05 Thread Eric Engestrom
On Thursday, 2018-07-05 15:17:51 +0200, Mathieu Bridon wrote: > The XML parser wants byte strings, not unicode strings. > > In both Python 2 and 3, opening a file without specifying the mode will > open it for reading in text mode ('r'). > > On Python 2, the read() method of the file object will

Re: [Mesa-dev] [PATCH 20/26] python: Open file in binary mode

2018-07-05 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-05 06:17:51) > The XML parser wants byte strings, not unicode strings. > > In both Python 2 and 3, opening a file without specifying the mode will > open it for reading in text mode ('r'). > > On Python 2, the read() method of the file ob

[Mesa-dev] [PATCH 20/26] python: Open file in binary mode

2018-07-05 Thread Mathieu Bridon
The XML parser wants byte strings, not unicode strings. In both Python 2 and 3, opening a file without specifying the mode will open it for reading in text mode ('r'). On Python 2, the read() method of the file object will return byte strings, while on Python 3 it will return unicode strings. Ex