Re: [Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

2017-09-18 Thread Chad Versace
On Fri 15 Sep 2017, zhoucm1 wrote: > > > On 2017年09月14日 07:03, Chad Versace wrote: > > From: Chad Versace > > > > This implementation is correct (afaict), but takes two shortcuts > > regarding the import/export of Android sync fds. > > > >Shortcut 1. When Android calls vkAcquireImageANDROI

Re: [Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

2017-09-14 Thread zhoucm1
On 2017年09月14日 07:03, Chad Versace wrote: From: Chad Versace This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the dri

Re: [Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

2017-09-14 Thread Chad Versace
On Thu 14 Sep 2017, Tapani Pälli wrote: > > > On 09/14/2017 08:51 AM, Tapani Pälli wrote: > > > > > > On 09/14/2017 02:03 AM, Chad Versace wrote: > > > From: Chad Versace > > > > > > This implementation is correct (afaict), but takes two shortcuts > > > regarding the import/export of Android

Re: [Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

2017-09-13 Thread Tapani Pälli
On 09/14/2017 08:51 AM, Tapani Pälli wrote: On 09/14/2017 02:03 AM, Chad Versace wrote: From: Chad Versace This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a

Re: [Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

2017-09-13 Thread Tapani Pälli
On 09/14/2017 02:03 AM, Chad Versace wrote: From: Chad Versace This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the d

[Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

2017-09-13 Thread Chad Versace
From: Chad Versace This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the driver instead simply blocks on the sync fd, then