Re: [Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

2017-03-22 Thread Chad Versace
On Wed 22 Mar 2017, Jason Ekstrand wrote: > On Wed, Mar 22, 2017 at 2:02 PM, Chad Versace > wrote: > > > On Wed 22 Mar 2017, Jason Ekstrand wrote: > > > Wow... This is an impressive quantity of infastructure just to get the > > > number of bits in a field... > > > > In the initial patch, I hand-w

Re: [Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

2017-03-22 Thread Jason Ekstrand
On Wed, Mar 22, 2017 at 2:02 PM, Chad Versace wrote: > On Wed 22 Mar 2017, Jason Ekstrand wrote: > > Wow... This is an impressive quantity of infastructure just to get the > > number of bits in a field... > > In the initial patch, I hand-wrote macros and functions. And I made > mistakes. That's w

Re: [Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

2017-03-22 Thread Chad Versace
On Wed 22 Mar 2017, Emil Velikov wrote: > Hi Chad, > > Please keep Tapani in Cc for the next revision - I think he can manage > the Android bits required. Will do. Also, I'm currently doing an initial build of android-ia, so I can stay on top of the Android changes along with Tapani. > There's

Re: [Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

2017-03-22 Thread Chad Versace
On Wed 22 Mar 2017, Jason Ekstrand wrote: > Wow... This is an impressive quantity of infastructure just to get the > number of bits in a field... In the initial patch, I hand-wrote macros and functions. And I made mistakes. That's when I decided to eliminate the mistakes with generation. That's wh

Re: [Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

2017-03-22 Thread Emil Velikov
Hi Chad, Please keep Tapani in Cc for the next revision - I think he can manage the Android bits required. There's a few small requests below, but don't bother if they're too time consuming. On 21 March 2017 at 23:02, Chad Versace wrote: > +genxml/genX_bits.h: genxml/gen_bits_header.py > +genx

Re: [Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

2017-03-22 Thread Jason Ekstrand
Wow... This is an impressive quantity of infastructure just to get the number of bits in a field... On Tue, Mar 21, 2017 at 4:02 PM, Chad Versace wrote: > genX_bits.h contains the sizes of bitfields in genxml instructions, > structures, and registers. It also defines some functions to query thos

[Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

2017-03-21 Thread Chad Versace
genX_bits.h contains the sizes of bitfields in genxml instructions, structures, and registers. It also defines some functions to query those sizes. Currently, the bitfields in genX_bits.h are those whose name matches /.*Surface(Q?)Pitch/. isl_surf_init() will use the new header to validate that r