Re: [Mesa-dev] [PATCH 2/7] vbo: Add a predraw resolve callback

2015-09-30 Thread Chad Versace
On Sat 12 Sep 2015, Chris Wilson wrote: > On Thu, Sep 10, 2015 at 08:41:37AM +0100, Chris Wilson wrote: > > http://people.freedesktop.org/~ickle/vbo/ > > > > ministat 63c4b7e_bench_synmark:OglBatch7 2fbce8b_bench_synmark:OglBatch7 > > x 63c4b7e_bench_synmark:OglBatch7 > > + 2fbce8b_bench_synmark:O

Re: [Mesa-dev] [PATCH 2/7] vbo: Add a predraw resolve callback

2015-09-12 Thread Chris Wilson
On Thu, Sep 10, 2015 at 08:41:37AM +0100, Chris Wilson wrote: > http://people.freedesktop.org/~ickle/vbo/ > > ministat 63c4b7e_bench_synmark:OglBatch7 2fbce8b_bench_synmark:OglBatch7 > x 63c4b7e_bench_synmark:OglBatch7 > + 2fbce8b_bench_synmark:OglBatch7 > +

Re: [Mesa-dev] [PATCH 2/7] vbo: Add a predraw resolve callback

2015-09-10 Thread Marek Olšák
Hi Chris, Instead of the nop functions, could you just do: if (vbo_context(ctx)->resolve) vbo_context(ctx)->resolve(ctx); Marek On Wed, Sep 9, 2015 at 3:38 PM, Chris Wilson wrote: > A common problem with using HiZ and multisampling is that surfaces need > to resolved prior to use. Currently

Re: [Mesa-dev] [PATCH 2/7] vbo: Add a predraw resolve callback

2015-09-10 Thread Chris Wilson
On Wed, Sep 09, 2015 at 10:19:10AM -0700, Ian Romanick wrote: > On 09/09/2015 10:10 AM, Kenneth Graunke wrote: > > On Wednesday, September 09, 2015 02:38:56 PM Chris Wilson wrote: > >> A common problem with using HiZ and multisampling is that surfaces need > >> to resolved prior to use. Currently i

Re: [Mesa-dev] [PATCH 2/7] vbo: Add a predraw resolve callback

2015-09-09 Thread Kenneth Graunke
On Wednesday, September 09, 2015 10:19:10 AM Ian Romanick wrote: > On 09/09/2015 10:10 AM, Kenneth Graunke wrote: > > On Wednesday, September 09, 2015 02:38:56 PM Chris Wilson wrote: > >> A common problem with using HiZ and multisampling is that surfaces need > >> to resolved prior to use. Currentl

Re: [Mesa-dev] [PATCH 2/7] vbo: Add a predraw resolve callback

2015-09-09 Thread Ian Romanick
On 09/09/2015 10:10 AM, Kenneth Graunke wrote: > On Wednesday, September 09, 2015 02:38:56 PM Chris Wilson wrote: >> A common problem with using HiZ and multisampling is that surfaces need >> to resolved prior to use. Currently i965 does this inside its state >> update hook, but that is a comparati

Re: [Mesa-dev] [PATCH 2/7] vbo: Add a predraw resolve callback

2015-09-09 Thread Kenneth Graunke
On Wednesday, September 09, 2015 02:38:56 PM Chris Wilson wrote: > A common problem with using HiZ and multisampling is that surfaces need > to resolved prior to use. Currently i965 does this inside its state > update hook, but that is a comparatively heavyweight operation that need > not be perfor

[Mesa-dev] [PATCH 2/7] vbo: Add a predraw resolve callback

2015-09-09 Thread Chris Wilson
A common problem with using HiZ and multisampling is that surfaces need to resolved prior to use. Currently i965 does this inside its state update hook, but that is a comparatively heavyweight operation that need not be performed so frequently. The obvious solution (and therefore fraught with drago