Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

2018-10-16 Thread Jason Ekstrand
On Tue, Oct 16, 2018 at 7:51 PM Matt Turner wrote: > On Sun, Oct 14, 2018 at 3:58 PM Jason Ekstrand > wrote: > > > > On October 14, 2018 17:12:34 Matt Turner wrote: > > > > > From: Jason Ekstrand > > > > > > [mattst88]: Found in an old branch of Jason's. > > > > > > Jason implemented: inot, ia

Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

2018-10-16 Thread Matt Turner
On Sun, Oct 14, 2018 at 3:58 PM Jason Ekstrand wrote: > > On October 14, 2018 17:12:34 Matt Turner wrote: > > > From: Jason Ekstrand > > > > [mattst88]: Found in an old branch of Jason's. > > > > Jason implemented: inot, iand, ior, iadd, isub, ineg, iabs, compare, > > imin, ima

Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

2018-10-15 Thread Jason Ekstrand
On Mon, Oct 15, 2018 at 3:13 PM Connor Abbott wrote: > On Mon, Oct 15, 2018 at 8:41 PM Jason Ekstrand > wrote: > > > > On Mon, Oct 15, 2018 at 1:39 PM Ian Romanick > wrote: > >> > >> On 10/14/2018 03:58 PM, Jason Ekstrand wrote: > >> > On October 14, 2018 17:12:34 Matt Turner wrote: > >> >> +s

Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

2018-10-15 Thread Connor Abbott
On Mon, Oct 15, 2018 at 8:41 PM Jason Ekstrand wrote: > > On Mon, Oct 15, 2018 at 1:39 PM Ian Romanick wrote: >> >> On 10/14/2018 03:58 PM, Jason Ekstrand wrote: >> > On October 14, 2018 17:12:34 Matt Turner wrote: >> >> +static nir_ssa_def * >> >> +lower_iabs64(nir_builder *b, nir_ssa_def *x) >

Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

2018-10-15 Thread Jason Ekstrand
On Mon, Oct 15, 2018 at 1:39 PM Ian Romanick wrote: > On 10/14/2018 03:58 PM, Jason Ekstrand wrote: > > On October 14, 2018 17:12:34 Matt Turner wrote: > >> +static nir_ssa_def * > >> +lower_iabs64(nir_builder *b, nir_ssa_def *x) > >> +{ > >> + nir_ssa_def *x_hi = nir_unpack_64_2x32_split_y(b,

Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

2018-10-15 Thread Ian Romanick
On 10/14/2018 03:58 PM, Jason Ekstrand wrote: > On October 14, 2018 17:12:34 Matt Turner wrote: >> +static nir_ssa_def * >> +lower_iabs64(nir_builder *b, nir_ssa_def *x) >> +{ >> +   nir_ssa_def *x_hi = nir_unpack_64_2x32_split_y(b, x); >> +   nir_ssa_def *x_is_neg = nir_ilt(b, x_hi, nir_imm_int(b

Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

2018-10-14 Thread Jason Ekstrand
On October 14, 2018 17:12:34 Matt Turner wrote: From: Jason Ekstrand [mattst88]: Found in an old branch of Jason's. Jason implemented: inot, iand, ior, iadd, isub, ineg, iabs, compare, imin, imax, umin, umax Matt implemented: ixor, imov, bcsel --- src/compiler/nir/nir_lowe

[Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

2018-10-14 Thread Matt Turner
From: Jason Ekstrand [mattst88]: Found in an old branch of Jason's. Jason implemented: inot, iand, ior, iadd, isub, ineg, iabs, compare, imin, imax, umin, umax Matt implemented: ixor, imov, bcsel --- src/compiler/nir/nir_lower_int64.c | 186 ++