Re: [Mesa-dev] [PATCH 2/7] glcpp: don't push #line directives into next line

2012-11-09 Thread Carl Worth
Kenneth Graunke writes: > Wow, this patch so looks like superfluous code motion. Right. We totally missed that when looking at the patch in bugzilla. > Would you mind adding something t othat effect to the commit message? Good idea. > Either way, this series is: > Reviewed-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 2/7] glcpp: don't push #line directives into next line

2012-11-08 Thread Kenneth Graunke
On 11/08/2012 05:26 PM, Matt Turner wrote: From: Fabian Bieler mattst88: Carl and I determined independently of Fabian that the 091 test needed to be modified identically to this, and our patch to fix the test was more complicated. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51506 R

[Mesa-dev] [PATCH 2/7] glcpp: don't push #line directives into next line

2012-11-08 Thread Matt Turner
From: Fabian Bieler mattst88: Carl and I determined independently of Fabian that the 091 test needed to be modified identically to this, and our patch to fix the test was more complicated. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51506 Reviewed-by: Matt Turner --- Patch 1/7 is "gl