Re: [Mesa-dev] [PATCH 2/6] nvc0: rework nvc0_compute_validate_program()

2016-02-21 Thread Samuel Pitoiset
On 02/22/2016 12:19 AM, Ilia Mirkin wrote: Should you instead move nvc0_compute_validate into nvc0_shader_state? Currently that's where all this stuff lives. I see nvc0_program_validate as more of an "internal" module function that shouldn't be exported across files. Fine by me. On Sun, Fe

Re: [Mesa-dev] [PATCH 2/6] nvc0: rework nvc0_compute_validate_program()

2016-02-21 Thread Ilia Mirkin
Should you instead move nvc0_compute_validate into nvc0_shader_state? Currently that's where all this stuff lives. I see nvc0_program_validate as more of an "internal" module function that shouldn't be exported across files. On Sun, Feb 21, 2016 at 9:19 AM, Samuel Pitoiset wrote: > Reduce the amo

[Mesa-dev] [PATCH 2/6] nvc0: rework nvc0_compute_validate_program()

2016-02-21 Thread Samuel Pitoiset
Reduce the amount of duplicated code by re-using nvc0_program_validate(). While we are at it, change the prototype to return void. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c| 32 ++ src/gallium/drivers/nouveau/nvc0/nvc0_compute.h