Re: [Mesa-dev] [PATCH 2/5] egl/android: use strcmp with drmVersion::name

On Tue, Aug 14, 2018 at 12:47 AM Emil Velikov wrote: > > On 13 August 2018 at 16:21, Tomasz Figa wrote: > > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov > > wrote: > >> > >> From: Emil Velikov > >> > >> The name string is guaranteed to be NULL terminated. Drop the explicit > >> length check t

Re: [Mesa-dev] [PATCH 2/5] egl/android: use strcmp with drmVersion::name

On 13 August 2018 at 16:21, Tomasz Figa wrote: > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov > wrote: >> >> From: Emil Velikov >> >> The name string is guaranteed to be NULL terminated. Drop the explicit >> length check that comes with strncmp(). > > Is there anything wrong with that length c

Re: [Mesa-dev] [PATCH 2/5] egl/android: use strcmp with drmVersion::name

On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov wrote: > > From: Emil Velikov > > The name string is guaranteed to be NULL terminated. Drop the explicit > length check that comes with strncmp(). Is there anything wrong with that length check? I feel like it's a good practice to keep it anyway. Be

[Mesa-dev] [PATCH 2/5] egl/android: use strcmp with drmVersion::name

From: Emil Velikov The name string is guaranteed to be NULL terminated. Drop the explicit length check that comes with strncmp(). Cc: Robert Foss Cc: Tomasz Figa Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif