Tom Stellard writes:
> From: Matt Arsenault
>
> If there were only warnings, they would not be added to the log.
> Also fixes valgrind use after free errors.
>
This last comment is somewhat misleading now, as this doesn't fix any
valgrind errors anymore. Without it, this patch is:
Reviewed-by
From: Matt Arsenault
If there were only warnings, they would not be added to the log.
Also fixes valgrind use after free errors.
v2:
- Use compat::string.
---
src/gallium/state_trackers/clover/core/compiler.hpp | 3 ++-
src/gallium/state_trackers/clover/core/error.hpp | 4 ++--
src/g
Tom Stellard writes:
>[...]
Hi Tom,
> Even with your patch, I'm still having trouble getting this to work.
What problem are you having?
> What is the correct pattern here? I know I need to use compat::string
> in the function signature, but what type should I pass to the
> compile_program_llv
On Sat, Jun 21, 2014 at 06:33:17PM +0200, Francisco Jerez wrote:
> Tom Stellard writes:
>
> > From: Matt Arsenault
> >
> > If there were only warnings, they would not be added to the log.
> > Also fixes valgrind use after free errors.
> > ---
> > src/gallium/state_trackers/clover/core/compiler.
Tom Stellard writes:
> From: Matt Arsenault
>
> If there were only warnings, they would not be added to the log.
> Also fixes valgrind use after free errors.
> ---
> src/gallium/state_trackers/clover/core/compiler.hpp | 3 ++-
> src/gallium/state_trackers/clover/core/error.hpp | 2 +-
>
From: Matt Arsenault
If there were only warnings, they would not be added to the log.
Also fixes valgrind use after free errors.
---
src/gallium/state_trackers/clover/core/compiler.hpp | 3 ++-
src/gallium/state_trackers/clover/core/error.hpp | 2 +-
src/gallium/state_trackers/clover/co
