Re: [Mesa-dev] [PATCH 2/5] clover: Fix not setting build log if the build succeeds v2

2014-06-26 Thread Francisco Jerez
Tom Stellard writes: > From: Matt Arsenault > > If there were only warnings, they would not be added to the log. > Also fixes valgrind use after free errors. > This last comment is somewhat misleading now, as this doesn't fix any valgrind errors anymore. Without it, this patch is: Reviewed-by

[Mesa-dev] [PATCH 2/5] clover: Fix not setting build log if the build succeeds v2

2014-06-25 Thread Tom Stellard
From: Matt Arsenault If there were only warnings, they would not be added to the log. Also fixes valgrind use after free errors. v2: - Use compat::string. --- src/gallium/state_trackers/clover/core/compiler.hpp | 3 ++- src/gallium/state_trackers/clover/core/error.hpp | 4 ++-- src/g