Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-06 Thread Emil Velikov
On 6 November 2015 at 18:01, Liu, Leo wrote: > >>> +#if GALLIUM_STATIC_TARGETS >>> + vscreen->pscreen = dd_create_screen(fd); >>> +#else >>> + if (pipe_loader_drm_probe_fd(&vscreen->dev, fd)) { >>Add a dup() in the above. So that it reads >> >>if (pipe_loader_drm_probe_fd(&vscreen->dev, dup(fd

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-06 Thread Liu, Leo
>> +#if GALLIUM_STATIC_TARGETS >> + vscreen->pscreen = dd_create_screen(fd); >> +#else >> + if (pipe_loader_drm_probe_fd(&vscreen->dev, fd)) { >Add a dup() in the above. So that it reads > >if (pipe_loader_drm_probe_fd(&vscreen->dev, dup(fd))) { > The dup is handled is in st/va/context.c befo

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-06 Thread Emil Velikov
On 5 November 2015 at 18:47, Leo Liu wrote: > This will allow the state trackers to use render nodes > with screen creation > > Signed-off-by: Leo Liu > --- > src/gallium/auxiliary/Makefile.sources | 3 +- > src/gallium/auxiliary/vl/vl_winsys.h | 6 +++ > src/gallium/auxiliary/vl/vl_wins

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 19:43, Christian König wrote: >> >> +/** >> + * >> + * Copyright 2009 Younes Manton. >> + * All Rights Reserved. > > You probably want to change the copyright here. > Heh considering that 90% of the follo

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-05 Thread Christian König
+/** + * + * Copyright 2009 Younes Manton. + * All Rights Reserved. You probably want to change the copyright here. With that fixed the whole series is Reviewed-by: Christian König Regards, Christian. On 05.11.2015 19:

[Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-05 Thread Leo Liu
This will allow the state trackers to use render nodes with screen creation Signed-off-by: Leo Liu --- src/gallium/auxiliary/Makefile.sources | 3 +- src/gallium/auxiliary/vl/vl_winsys.h | 6 +++ src/gallium/auxiliary/vl/vl_winsys_drm.c | 76 3 files chan