Re: [Mesa-dev] [PATCH 2/4] glsl: fix bitfield_insert use when doing ldexp lowering

2014-04-25 Thread Ilia Mirkin
On Fri, Apr 25, 2014 at 2:44 PM, Ilia Mirkin wrote: > On Fri, Apr 25, 2014 at 2:38 PM, Matt Turner wrote: >> On Fri, Apr 25, 2014 at 10:41 AM, Ilia Mirkin wrote: >>> bitfield_insert expects glsl_type::int_type arguments, not uint vectors >>> >>> Signed-off-by: Ilia Mirkin >>> --- >>> >>> Identi

Re: [Mesa-dev] [PATCH 2/4] glsl: fix bitfield_insert use when doing ldexp lowering

2014-04-25 Thread Ilia Mirkin
On Fri, Apr 25, 2014 at 2:38 PM, Matt Turner wrote: > On Fri, Apr 25, 2014 at 10:41 AM, Ilia Mirkin wrote: >> bitfield_insert expects glsl_type::int_type arguments, not uint vectors >> >> Signed-off-by: Ilia Mirkin >> --- >> >> Identical to the patch I sent out last night. Without it ldexp lower

Re: [Mesa-dev] [PATCH 2/4] glsl: fix bitfield_insert use when doing ldexp lowering

2014-04-25 Thread Matt Turner
On Fri, Apr 25, 2014 at 10:41 AM, Ilia Mirkin wrote: > bitfield_insert expects glsl_type::int_type arguments, not uint vectors > > Signed-off-by: Ilia Mirkin > --- > > Identical to the patch I sent out last night. Without it ldexp lowering > (without bfi lowering) causes assertion failures in the

[Mesa-dev] [PATCH 2/4] glsl: fix bitfield_insert use when doing ldexp lowering

2014-04-25 Thread Ilia Mirkin
bitfield_insert expects glsl_type::int_type arguments, not uint vectors Signed-off-by: Ilia Mirkin --- Identical to the patch I sent out last night. Without it ldexp lowering (without bfi lowering) causes assertion failures in the next mesa/st patch. src/glsl/lower_instructions.cpp | 6 +++---