Re: [Mesa-dev] [PATCH 2/4] anv/image: Simplify initialization of the isl_tiling

2016-07-06 Thread Chad Versace
On Fri 01 Jul 2016, Nanley Chery wrote: > On Fri, Jul 01, 2016 at 02:24:19PM -0700, Chad Versace wrote: > > I don't agree with this patch. > > > > Locally, the patch look correct. But when you consider that > > anv_image_create() is public within the driver, the patch makes the code > > fragile.

Re: [Mesa-dev] [PATCH 2/4] anv/image: Simplify initialization of the isl_tiling

2016-07-01 Thread Jason Ekstrand
On Fri, Jul 1, 2016 at 6:13 PM, Nanley Chery wrote: > On Fri, Jul 01, 2016 at 02:24:19PM -0700, Chad Versace wrote: > > On Mon 27 Jun 2016, Nanley Chery wrote: > > > Signed-off-by: Nanley Chery > > > --- > > > src/intel/vulkan/anv_image.c | 10 -- > > > 1 file changed, 4 insertions(+),

Re: [Mesa-dev] [PATCH 2/4] anv/image: Simplify initialization of the isl_tiling

2016-07-01 Thread Nanley Chery
On Fri, Jul 01, 2016 at 02:24:19PM -0700, Chad Versace wrote: > On Mon 27 Jun 2016, Nanley Chery wrote: > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/anv_image.c | 10 -- > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/src/intel/vulkan/anv_image.c

Re: [Mesa-dev] [PATCH 2/4] anv/image: Simplify initialization of the isl_tiling

2016-07-01 Thread Chad Versace
On Mon 27 Jun 2016, Nanley Chery wrote: > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_image.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c > index 77d9931..b3f5f5c 100644 > --- a/src/i

[Mesa-dev] [PATCH 2/4] anv/image: Simplify initialization of the isl_tiling

2016-06-27 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 77d9931..b3f5f5c 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/anv_image