Re: [Mesa-dev] [PATCH 2/3] nvc0/ir: remove useless NVC0LoweringPass::gMemBase

2016-10-19 Thread Samuel Pitoiset
On 10/19/2016 11:41 PM, Ilia Mirkin wrote: On Wed, Oct 19, 2016 at 5:33 PM, Samuel Pitoiset wrote: On 10/19/2016 11:29 PM, Ilia Mirkin wrote: It avoids creating a ton of symbols unnecessarily during the lifetime of the pass. Does it hurt anything? I think either we use that symbol ever

Re: [Mesa-dev] [PATCH 2/3] nvc0/ir: remove useless NVC0LoweringPass::gMemBase

2016-10-19 Thread Ilia Mirkin
On Wed, Oct 19, 2016 at 5:33 PM, Samuel Pitoiset wrote: > > > On 10/19/2016 11:29 PM, Ilia Mirkin wrote: >> >> It avoids creating a ton of symbols unnecessarily during the lifetime >> of the pass. Does it hurt anything? > > > I think either we use that symbol everywhere we can, or we simply remove

Re: [Mesa-dev] [PATCH 2/3] nvc0/ir: remove useless NVC0LoweringPass::gMemBase

2016-10-19 Thread Samuel Pitoiset
On 10/19/2016 11:29 PM, Ilia Mirkin wrote: It avoids creating a ton of symbols unnecessarily during the lifetime of the pass. Does it hurt anything? I think either we use that symbol everywhere we can, or we simply remove it. We don't even use it for GF100 atomic operations. On Wed, Oct

Re: [Mesa-dev] [PATCH 2/3] nvc0/ir: remove useless NVC0LoweringPass::gMemBase

2016-10-19 Thread Ilia Mirkin
It avoids creating a ton of symbols unnecessarily during the lifetime of the pass. Does it hurt anything? On Wed, Oct 19, 2016 at 5:21 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 5 + > 1 file changed, 1

[Mesa-dev] [PATCH 2/3] nvc0/ir: remove useless NVC0LoweringPass::gMemBase

2016-10-19 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp i