Re: [Mesa-dev] [PATCH 2/3] mesa: replace date/time macros with MESA_GIT_SHA1

2017-09-05 Thread Emil Velikov
On 5 September 2017 at 15:51, Rob Herring wrote: > On Tue, Sep 5, 2017 at 9:23 AM, Emil Velikov wrote: >> From: Emil Velikov >> >> Former is non-deterministic and compilers throw a warning about it. >> >> Cc: Rob Herring >> Signed-off-by: Emil Velikov >> --- >> I think the patch is a good idea

Re: [Mesa-dev] [PATCH 2/3] mesa: replace date/time macros with MESA_GIT_SHA1

2017-09-05 Thread Eero Tamminen
Hi, On 05.09.2017 17:23, Emil Velikov wrote: From: Emil Velikov Former is non-deterministic and compilers throw a warning about it. Cc: Rob Herring Signed-off-by: Emil Velikov --- I think the patch is a good idea, although kind of split about it. Any arguments for/against would be appreciat

Re: [Mesa-dev] [PATCH 2/3] mesa: replace date/time macros with MESA_GIT_SHA1

2017-09-05 Thread Rob Herring
On Tue, Sep 5, 2017 at 9:23 AM, Emil Velikov wrote: > From: Emil Velikov > > Former is non-deterministic and compilers throw a warning about it. > > Cc: Rob Herring > Signed-off-by: Emil Velikov > --- > I think the patch is a good idea, although kind of split about it. > Any arguments for/again

Re: [Mesa-dev] [PATCH 2/3] mesa: replace date/time macros with MESA_GIT_SHA1

2017-09-05 Thread Eric Engestrom
On Tuesday, 2017-09-05 15:23:24 +0100, Emil Velikov wrote: > From: Emil Velikov > > Former is non-deterministic and compilers throw a warning about it. > > Cc: Rob Herring > Signed-off-by: Emil Velikov > --- > I think the patch is a good idea, although kind of split about it. > Any arguments f

[Mesa-dev] [PATCH 2/3] mesa: replace date/time macros with MESA_GIT_SHA1

2017-09-05 Thread Emil Velikov
From: Emil Velikov Former is non-deterministic and compilers throw a warning about it. Cc: Rob Herring Signed-off-by: Emil Velikov --- I think the patch is a good idea, although kind of split about it. Any arguments for/against would be appreciated. --- src/mesa/main/context.c | 10 +++---