Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-23 Thread Kristian Høgsberg
On Fri, Oct 23, 2015 at 5:38 AM, Francisco Jerez wrote: > Kristian Høgsberg writes: > >> On Tue, Oct 20, 2015 at 11:56 AM, Francisco Jerez >> wrote: >>> Kristian Høgsberg writes: >>> On Tue, Oct 20, 2015 at 3:16 AM, Francisco Jerez wrote: > Kristian Høgsberg writes: >

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-23 Thread Francisco Jerez
Kristian Høgsberg writes: > On Tue, Oct 20, 2015 at 11:56 AM, Francisco Jerez > wrote: >> Kristian Høgsberg writes: >> >>> On Tue, Oct 20, 2015 at 3:16 AM, Francisco Jerez >>> wrote: Kristian Høgsberg writes: > On Mon, Oct 19, 2015 at 4:19 AM, Francisco Jerez > wrote: >>

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-22 Thread Kristian Høgsberg
On Tue, Oct 20, 2015 at 11:56 AM, Francisco Jerez wrote: > Kristian Høgsberg writes: > >> On Tue, Oct 20, 2015 at 3:16 AM, Francisco Jerez >> wrote: >>> Kristian Høgsberg writes: >>> On Mon, Oct 19, 2015 at 4:19 AM, Francisco Jerez wrote: > Neil Roberts writes: > >> Ju

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-20 Thread Francisco Jerez
Kristian Høgsberg writes: > On Tue, Oct 20, 2015 at 3:16 AM, Francisco Jerez > wrote: >> Kristian Høgsberg writes: >> >>> On Mon, Oct 19, 2015 at 4:19 AM, Francisco Jerez >>> wrote: Neil Roberts writes: > Just a thought, would it be better to move this check into the > eli

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-20 Thread Kristian Høgsberg
On Tue, Oct 20, 2015 at 3:16 AM, Francisco Jerez wrote: > Kristian Høgsberg writes: > >> On Mon, Oct 19, 2015 at 4:19 AM, Francisco Jerez >> wrote: >>> Neil Roberts writes: >>> Just a thought, would it be better to move this check into the eliminate_find_live_channel optimisation? Th

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-20 Thread Francisco Jerez
Kristian Høgsberg writes: > On Mon, Oct 19, 2015 at 4:19 AM, Francisco Jerez > wrote: >> Neil Roberts writes: >> >>> Just a thought, would it be better to move this check into the >>> eliminate_find_live_channel optimisation? That way it could catch >>> sources that become immediates through l

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-20 Thread Jordan Justen
I wrote a similar patch a while back because I was annoyed by how this was causing the send disassembly to not be as nice. :) I dropped it from my branch at some point, but I still think it is a good idea. Reviewed-by: Jordan Justen On 2015-10-18 21:31:43, Kristian Høgsberg Kristensen wrote: > A

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-19 Thread Kristian Høgsberg
On Mon, Oct 19, 2015 at 4:19 AM, Francisco Jerez wrote: > Neil Roberts writes: > >> Just a thought, would it be better to move this check into the >> eliminate_find_live_channel optimisation? That way it could catch >> sources that become immediates through later optimisations. One problem >> wit

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-19 Thread Francisco Jerez
Neil Roberts writes: > Just a thought, would it be better to move this check into the > eliminate_find_live_channel optimisation? That way it could catch > sources that become immediates through later optimisations. One problem > with this that I've seen before is that eliminating the > FIND_LIVE

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-19 Thread Neil Roberts
Just a thought, would it be better to move this check into the eliminate_find_live_channel optimisation? That way it could catch sources that become immediates through later optimisations. One problem with this that I've seen before is that eliminating the FIND_LIVE_CHANNEL doesn't cause the subseq

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-19 Thread Iago Toral
On Sun, 2015-10-18 at 21:31 -0700, Kristian Høgsberg Kristensen wrote: > An immdiate is already uniform so just return it up front. Without this, > brw_fs_surface_builder ends up passing immediate surface indices through > SHADER_OPCODE_BROADCAST. This writes to a stride 0 dst, which we can't > con

[Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-18 Thread Kristian Høgsberg Kristensen
An immdiate is already uniform so just return it up front. Without this, brw_fs_surface_builder ends up passing immediate surface indices through SHADER_OPCODE_BROADCAST. This writes to a stride 0 dst, which we can't constant propagate out of, and further, we don't constant propagate into the typed