Re: [Mesa-dev] [PATCH 2/3] gallium/hud: fix a previously allocated handle.

2016-10-24 Thread Steven Toth
>> + if (!pdir) { >> + close(dir); > > > Shouldn't this be closedir(dir)? Whoops, Thank you for catching this. I'll re-issue the patch-set momentarily with this adjustment. -- Steven Toth - Kernel Labs http://www.kernellabs.com ___ mesa-d

Re: [Mesa-dev] [PATCH 2/3] gallium/hud: fix a previously allocated handle.

2016-10-24 Thread Nicolai Hähnle
On 20.10.2016 20:45, Steven Toth wrote: We're missing the closedir() to the matching opendir(). Signed-off-by: Steven Toth --- src/gallium/auxiliary/hud/hud_cpufreq.c | 1 + src/gallium/auxiliary/hud/hud_diskstat.c | 5 - src/gallium/auxiliary/hud/hud_nic.c | 1 + 3 files changed, 6

Re: [Mesa-dev] [PATCH 2/3] gallium/hud: fix a previously allocated handle.

2016-10-21 Thread Eduardo Lima Mitev
On 10/20/2016 08:45 PM, Steven Toth wrote: > We're missing the closedir() to the matching opendir(). > What about changing the commit title to: "gallium/hud: close a previously opened handle"? Either way: Reviewed-by: Eduardo Lima Mitev > Signed-off-by: Steven Toth > --- > src/gallium/auxil

[Mesa-dev] [PATCH 2/3] gallium/hud: fix a previously allocated handle.

2016-10-20 Thread Steven Toth
We're missing the closedir() to the matching opendir(). Signed-off-by: Steven Toth --- src/gallium/auxiliary/hud/hud_cpufreq.c | 1 + src/gallium/auxiliary/hud/hud_diskstat.c | 5 - src/gallium/auxiliary/hud/hud_nic.c | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a