Re: [Mesa-dev] [PATCH 2/2] radeonsi: Implement DMA blit

2014-03-17 Thread Niels Ole Salscheider
I have sent an updated version of the patch to the mailing list. I hope that the copyright header of si_dma.c is right - I copied it from si_hw_context.c... Ole On Monday 17 March 2014, 02:33:35, Marek Olšák wrote: > Thanks for doing this! I have some comments... > > 1) As of SI, the maximum su

[Mesa-dev] [PATCH 2/2] radeonsi: Implement DMA blit

2014-03-17 Thread Niels Ole Salscheider
This code is a slightly modified version of evergreen_dma_blit (and evergreen_dma_copy as well as evergreen_dma_copy_tile). It would be nice to share some of the code in the long term. I have reused some "cik"-prefixed functions that also return the right value for SI. I am not sure if they should

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Implement DMA blit

2014-03-16 Thread Marek Olšák
Thanks for doing this! I have some comments... 1) As of SI, the maximum supported size for dword-aligned L2L, L2T, and T2L copies is 0x8. The maximum supported size for byte-aligned L2L copies is 0xfffe0. I'd like to have proper definitions for this, e.g. SI_DMA_COPY_MAX_SIZE and SI_DMA_COPY_M

[Mesa-dev] [PATCH 2/2] radeonsi: Implement DMA blit

2014-03-13 Thread Niels Ole Salscheider
This code is a slightly modified version of evergreen_dma_blit (and evergreen_dma_copy as well as evergreen_dma_copy_tile). It would be nice to share some of the code in the long term. I have reused some "cik"-prefixed functions that also return the right value for SI. I am not sure if they should