Re: [Mesa-dev] [PATCH 2/2] panfrost: Implement Midgard shader toolchain

2019-02-04 Thread Alyssa Rosenzweig
> Top of src/util/ralloc.h? Ah-ha, thank you! Suddenly mesa makes so much more sense :) > Counting uniforms/attributes is all a confusing mess. I can confirm > that what I do in v3d works, I just can't explain how without going and > re-studying it. Alright, I'll look there, thank you :) > Bas

Re: [Mesa-dev] [PATCH 2/2] panfrost: Implement Midgard shader toolchain

2019-02-04 Thread Eric Anholt
Alyssa Rosenzweig writes: >> Looks like you leak the constants? You could pass ctx->ssa_constants >> instead of NULL and the allocation would be automatically freed. > > Hm, alright. Is there documentation anywhere on how memctx works in > general? Top of src/util/ralloc.h? >> > +nir_f

Re: [Mesa-dev] [PATCH 2/2] panfrost: Implement Midgard shader toolchain

2019-02-03 Thread Alyssa Rosenzweig
> Looks like you leak the constants? You could pass ctx->ssa_constants > instead of NULL and the allocation would be automatically freed. Hm, alright. Is there documentation anywhere on how memctx works in general? > Instead of hardcoding 4096, use impl->ssa_index? Good catch, thank you. > Loo

Re: [Mesa-dev] [PATCH 2/2] panfrost: Implement Midgard shader toolchain

2019-01-31 Thread Eric Anholt
Alyssa Rosenzweig writes: > This patch implements the free Midgard shader toolchain: the assembler, > the disassembler, and the NIR-based compiler. The assembler is a > standalone inaccessible Python script for reference purposes. The > disassembler and the compiler are implemented in C, accessib