Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-12 Thread Rob Clark
On Tue, Jun 12, 2018 at 3:36 PM, Jason Ekstrand wrote: > On Tue, Jun 12, 2018 at 10:49 AM, Rob Clark wrote: >> >> On Mon, Jun 11, 2018 at 10:59 PM, Roland Scheidegger >> wrote: >> > Am 12.06.2018 um 01:17 schrieb Rob Clark: >> >> On Mon, Jun 11, 2018 at 6:59 PM, Roland Scheidegger >> >> wrote:

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-12 Thread Jason Ekstrand
On Tue, Jun 12, 2018 at 10:49 AM, Rob Clark wrote: > On Mon, Jun 11, 2018 at 10:59 PM, Roland Scheidegger > wrote: > > Am 12.06.2018 um 01:17 schrieb Rob Clark: > >> On Mon, Jun 11, 2018 at 6:59 PM, Roland Scheidegger > wrote: > >>> Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: > On Wed,

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-12 Thread Rob Clark
On Mon, Jun 11, 2018 at 10:59 PM, Roland Scheidegger wrote: > Am 12.06.2018 um 01:17 schrieb Rob Clark: >> On Mon, Jun 11, 2018 at 6:59 PM, Roland Scheidegger >> wrote: >>> Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark >>>

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Roland Scheidegger
Am 12.06.2018 um 01:17 schrieb Rob Clark: > On Mon, Jun 11, 2018 at 6:59 PM, Roland Scheidegger > wrote: >> Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: >>> On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark >> > wrote: >>> >>> Signed-off-by: Rob Clark >>

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Rob Clark
On Mon, Jun 11, 2018 at 6:59 PM, Roland Scheidegger wrote: > Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: >> On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark > > wrote: >> >> Signed-off-by: Rob Clark > > >> --- >> I can't say for s

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Jason Ekstrand
On Mon, Jun 11, 2018 at 3:59 PM, Roland Scheidegger wrote: > Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: > > On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark > > wrote: > > > > Signed-off-by: Rob Clark > > > > --- > > I can't s

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Roland Scheidegger
Am 12.06.2018 um 00:32 schrieb Jason Ekstrand: > On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark > wrote: > > Signed-off-by: Rob Clark > > --- > I can't say for sure that this will work on all drivers, but it is > what the blo

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Rob Clark
On Mon, Jun 11, 2018 at 6:34 PM, Jason Ekstrand wrote: > On Mon, Jun 11, 2018 at 3:32 PM, Jason Ekstrand > wrote: >> >> On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark wrote: >>> >>> Signed-off-by: Rob Clark >>> --- >>> I can't say for sure that this will work on all drivers, but it is >>> what the b

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Jason Ekstrand
On Mon, Jun 11, 2018 at 3:32 PM, Jason Ekstrand wrote: > On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark wrote: > >> Signed-off-by: Rob Clark >> --- >> I can't say for sure that this will work on all drivers, but it is >> what the blob driver does, and it seems to make deqp happy. I could >> move th

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-11 Thread Jason Ekstrand
On Wed, Jun 6, 2018 at 7:43 AM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > I can't say for sure that this will work on all drivers, but it is > what the blob driver does, and it seems to make deqp happy. I could > move this to it's own pass inside ir3, but that seemed like overkill > >

[Mesa-dev] [PATCH 2/2] nir: add lowering for gl_HelperInvocation

2018-06-06 Thread Rob Clark
Signed-off-by: Rob Clark --- I can't say for sure that this will work on all drivers, but it is what the blob driver does, and it seems to make deqp happy. I could move this to it's own pass inside ir3, but that seemed like overkill src/compiler/nir/nir.h | 10 ++ s